created a new frontend application using Typescript Nuxt3 Vue3 and pi… #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is a massive PR, out of curiosity, why are we doing this rewrite in the middle of the current implementation ? |
elhmn
requested changes
Apr 10, 2023
Member
elhmn
left a comment
elhmn
left a comment
There was a problem hiding this comment.
I think it is good if we understand why this is needed and if it can't wait for the current work to be done, so I left a question on the PR to clarify that
Member
Author
|
it's indeed a mistake to have tagged you on this, it should have waited and it currently has no priority. I was learning how the new stack works and built the project with it straight away as we had discussed it once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request create a new frontend application
Why ?
as the application grows it is important that it is more robust. the use of typescript facilitates this and also reduces runtime errors
How ?
i generated a new app using Nuxt3 and rewrite the App using the same components and pages
Steps to verify:
follows the same step as the steps of old app