Conversation
kaniko publishes its images for linux/amd64, arm64, s390x, riscv64 and ppc64le. Anyone running the helper standalone in those same places had nothing to download, we shipped linux amd64, arm64 and 386 only. The three missing arches are now built, and 32 bit arm with them, which is what docker on a raspberry pi running a 32 bit OS needs. Nothing in the code is architecture specific and CGO is already off, so this is targets and nothing else. build.yaml cross compiles every target on each PR via goreleaser build --snapshot, so the new ones are covered from here on. Left out on purpose: arm_6, which is a pi zero and a pi 1 and reaches end of the line, and loong64, mips and ppc64 big endian, which no consumer has asked for. They are one line each if that changes.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kaniko publishes its images for
linux/amd64,linux/arm64,linux/s390x,linux/riscv64,linux/ppc64le(.github/workflows/images.yaml). We shipped linux amd64, arm64 and 386 only, so anyone running the helper standalone in those same places had nothing to download. The three missing arches are now built, and 32 bit arm with them, which is what docker on a raspberry pi running a 32 bit OS needs.Windows on ARM and Apple Silicon were already covered,
windows_arm64anddarwin_arm64have been in the list since the fork.Nothing in the code is architecture specific and
CGO_ENABLED=0is already set, so this is targets and nothing else.build.yamlcross compiles every target on each PR withgoreleaser build --snapshot --clean, so the new ones are covered from here on.Verified locally with that same command, twelve artifacts, each confirmed with
file:Left out on purpose:
arm_6, which is a pi zero and a pi 1 and reaches end of the line; andloong64,mips*and big endianppc64, which no consumer has asked for. One line each if that changes.