Skip to content

cleanup #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mzihlmann merged 1 commit into from
Jul 8, 2025
Merged

cleanup #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,35 +6,23 @@ If you are new here, these are the main differences to the last official kaniko
* CVE-2025-22874: bump go 1.24.3 -> 1.24.4: https://github.com/mzihlmann/kaniko/pull/50
* remove binary artifacts: by @tlk in https://github.com/mzihlmann/kaniko/pull/54
### Bugfixes
* cache extract fails on invalid symlinks: https://github.com/mzihlmann/kaniko/pull/3 opened as https://github.com/GoogleContainerTools/kaniko/pull/3429
* cache extract fails on invalid symlinks: https://github.com/mzihlmann/kaniko/pull/3
* sticky bit gets lost on COPY: https://github.com/mzihlmann/kaniko/pull/45
* cache collision under rename: by @SJrX in https://github.com/mzihlmann/kaniko/pull/62
### Caching
* sourceImage's CreatedAt timestamp should not be included in cache key: https://github.com/mzihlmann/kaniko/pull/1 opened as https://github.com/GoogleContainerTools/kaniko/pull/3489
* ignore labels on base image for cache: https://github.com/mzihlmann/kaniko/pull/2 opened as https://github.com/GoogleContainerTools/kaniko/pull/3342
* intermediate images should not be labelled: https://github.com/mzihlmann/kaniko/pull/4 opened as https://github.com/GoogleContainerTools/kaniko/pull/3413
* Fix caching for empty RUN: https://github.com/mzihlmann/kaniko/pull/19 opened as https://github.com/GoogleContainerTools/kaniko/pull/3496
* WORKDIR learned to cache its potential output layer: https://github.com/mzihlmann/kaniko/pull/22 https://github.com/mzihlmann/kaniko/pull/23 opened as https://github.com/GoogleContainerTools/kaniko/pull/3341
* ADD learned to cache its output layer: https://github.com/mzihlmann/kaniko/pull/24 opened as https://github.com/GoogleContainerTools/kaniko/pull/3499
* sourceImage's CreatedAt timestamp should not be included in cache key: https://github.com/mzihlmann/kaniko/pull/1
* ignore labels on base image for cache: https://github.com/mzihlmann/kaniko/pull/2
* intermediate images should not be labelled: https://github.com/mzihlmann/kaniko/pull/4
* Fix caching for empty RUN: https://github.com/mzihlmann/kaniko/pull/19
* WORKDIR learned to cache its potential output layer: https://github.com/mzihlmann/kaniko/pull/22 https://github.com/mzihlmann/kaniko/pull/23
* ADD learned to cache its output layer: https://github.com/mzihlmann/kaniko/pull/24
### Optimizations
* if target stage is unspecified we now implicitly target the last stage: https://github.com/mzihlmann/kaniko/pull/27
### Bootstrap
* bootstrap image: https://github.com/mzihlmann/kaniko/pull/59
### Materialize Workflow
* kaniko learned `--preserve-context` to preserve the build-context across multi-stage builds: https://github.com/mzihlmann/kaniko/pull/28 opened as https://github.com/GoogleContainerTools/kaniko/pull/3500
* kaniko learned `--preserve-context` to preserve the build-context across multi-stage builds: https://github.com/mzihlmann/kaniko/pull/28
* kaniko learned `--materialize` forcing the filesystem into a well-defined state after the build: https://github.com/mzihlmann/kaniko/pull/29
### Maintenance
* chore(deps): bump github.com/google/go-containerregistry from 0.20.4 to 0.20.6: https://github.com/mzihlmann/kaniko/pull/41 https://github.com/mzihlmann/kaniko/pull/65
* chore(deps): bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.17.75 to 1.17.82: https://github.com/mzihlmann/kaniko/pull/58 https://github.com/mzihlmann/kaniko/pull/73 https://github.com/mzihlmann/kaniko/pull/74 https://github.com/mzihlmann/kaniko/pull/87
* chore(deps): bump github.com/GoogleCloudPlatform/docker-credential-gcr/v2 from 2.1.22 to 2.1.30: https://github.com/mzihlmann/kaniko/pull/40 https://github.com/mzihlmann/kaniko/pull/86
* chore(deps): bump cloud.google.com/go/storage from 1.54.0 to 1.55.0: https://github.com/mzihlmann/kaniko/pull/43
* chore(deps): bump github.com/go-git/go-git/v5 from 5.16.0 to 5.16.2: https://github.com/mzihlmann/kaniko/pull/66
* chore(deps): bump golang.org/x/sync from 0.14.0 to 0.15.0: https://github.com/mzihlmann/kaniko/pull/64
* chore(deps): bump google.golang.org/api from 0.235.0 to 0.239.0: https://github.com/mzihlmann/kaniko/pull/63 https://github.com/mzihlmann/kaniko/pull/71 https://github.com/mzihlmann/kaniko/pull/84
* chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.80.2 to 1.80.3: https://github.com/mzihlmann/kaniko/pull/70
* chore(deps): bump github.com/moby/buildkit from 0.22.0 to 0.23.1: https://github.com/mzihlmann/kaniko/pull/75 https://github.com/mzihlmann/kaniko/pull/79
* chore(deps): bump sigstore/cosign-installer from 3.9.0 to 3.9.1: https://github.com/mzihlmann/kaniko/pull/82
* chore(deps): bump github.com/docker/docker from 28.2.2+incompatible to 28.3.0+incompatible: https://github.com/mzihlmann/kaniko/pull/83
### Shoutout & Thanks
* 🔗 cleanup jobs: by @cpanato in https://github.com/mzihlmann/kaniko/pull/55
* 🔗 update ENV syntax in Dockerfile: by @babs in https://github.com/mzihlmann/kaniko/pull/60
Expand Down
11 changes: 3 additions & 8 deletions integration/images.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ var additionalKanikoFlagsMap = map[string][]string{
"Dockerfile_test_cache_copy": {"--cache-copy-layers=true"},
"Dockerfile_test_cache_copy_oci": {"--cache-copy-layers=true"},
"Dockerfile_test_issue_add": {"--cache-copy-layers=true"},
// skip-unused-stages
"Dockerfile_test_copy_chown_nonexisting_user": {"--skip-unused-stages"},
"Dockerfile_test_issue_1965": {"--skip-unused-stages"},
}

// Arguments to diffoci when comparing dockerfiles
Expand All @@ -107,13 +104,11 @@ var diffArgsMap = map[string][]string{
// docker is wrong. we do copy the symlink correctly.
"TestRun/test_Dockerfile_test_copy_symlink": {"--extra-ignore-files=workdirAnother/relative_link"},
"TestRun/test_Dockerfile_test_multistage": {"--extra-ignore-files=new"},
// docker is wrong. we set permissions to 777 as instructed, they set to 755
"TestRun/test_Dockerfile_test_copyadd_chmod": {"--extra-ignore-files=dir777/"},
// when we untar we overwrite the parent directory, buildx doesnt
// when we untar we overwrite the parent directory, buildkit doesnt
"TestRun/test_Dockerfile_test_add": {"--extra-ignore-file-permissions"},
// FROM scratch we start with root, buildx doesnt
// FROM scratch we start with root, buildkit doesnt
"TestRun/test_Dockerfile_test_workdir_with_user": {"--extra-ignore-file-permissions"},
// if group is not set, buildx defaults to 0
// if group is not set, buildkit defaults to 0
"TestRun/test_Dockerfile_test_user_nonexisting": {"--extra-ignore-file-permissions"},
// Somehow buildkit sets Uid of copied files to root=0 instead of active user.
"TestRun/test_Dockerfile_test_issue_3166": {"--extra-ignore-file-permissions"},
Expand Down
2 changes: 1 addition & 1 deletion integration/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ func TestBuildWithHTTPError(t *testing.T) {
}

func TestLayers(t *testing.T) {
// offset is caused because for those two files we use
// offset is caused because for those three files we use
// --single-snapshot option, compressing all layers into one
offset := map[string]int{
"Dockerfile_test_add": 12,
Expand Down
Loading