Skip to content

WORKDIR learned to cache it's potential output layer#22

Merged
mzihlmann merged 4 commits intomainfrom
workdir-cache-2
May 29, 2025
Merged

WORKDIR learned to cache it's potential output layer#22
mzihlmann merged 4 commits intomainfrom
workdir-cache-2

Conversation

@mzihlmann
Copy link
Collaborator

@mzihlmann mzihlmann commented May 29, 2025

Fixes GoogleContainerTools/kaniko#3340 GoogleContainerTools/kaniko#3246
Fixes GoogleContainerTools/kaniko#2533 https://github.com/chainguard-dev/kaniko/issues/227 (coincidentally)

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@mzihlmann mzihlmann force-pushed the workdir-cache-2 branch 2 times, most recently from 00a76f7 to 5bb0544 Compare May 29, 2025 21:59
@mzihlmann mzihlmann merged commit db53db7 into main May 29, 2025
9 checks passed
@mzihlmann
Copy link
Collaborator Author

mzihlmann commented Aug 29, 2025

this change coincidentally fixes GoogleContainerTools/kaniko#2533 & https://github.com/chainguard-dev/kaniko/issues/227 as with this change WORKDIR now sets RequiresUnpackedFS
not sure what triggered me to include this change, for sure it was some error message similar to what is described in the above, likely more discoverable as we're now caching things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

layer created implicitly by WORKDIR is not cached Regression regarding USER in 1.9.2

1 participant