Skip to content

cg188: secret mounts#391

Merged
mzihlmann merged 3 commits intomainfrom
cg188-secret-mounts
Nov 30, 2025
Merged

cg188: secret mounts#391
mzihlmann merged 3 commits intomainfrom
cg188-secret-mounts

Conversation

@mzihlmann
Copy link
Collaborator

@mzihlmann mzihlmann commented Nov 14, 2025

Fixes https://github.com/chainguard-dev/kaniko/issues/188 GoogleContainerTools/kaniko#3028

Description

Adds support for secret mount syntax. Note that this does not store the secrets securely, any secrets passed to kaniko must be considered exposed.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@mzihlmann mzihlmann force-pushed the cg188-secret-mounts branch 4 times, most recently from f74cef5 to 5bf48a1 Compare November 18, 2025 21:55
@mzihlmann mzihlmann requested review from 0hlov3, BobDu, babs and nejch November 18, 2025 21:58
@mzihlmann mzihlmann force-pushed the cg188-secret-mounts branch 5 times, most recently from 88c8a2e to ba3fdd5 Compare November 19, 2025 21:48
@mzihlmann mzihlmann marked this pull request as ready for review November 19, 2025 21:49
@mzihlmann
Copy link
Collaborator Author

I was having a think about how we expose the cli arg and I think docker is correct. We shouldnt push the anti-pattern of putting secrets onto the cli. As we're in k8s they anyways can only come in env variables or file, so the docker implementation is actually convenient.

@mzihlmann
Copy link
Collaborator Author

let me do the docker style cli arg in a second part as it would only explode the contents of this PR

@mzihlmann mzihlmann mentioned this pull request Nov 30, 2025
4 tasks
@mzihlmann mzihlmann merged commit f870971 into main Nov 30, 2025
12 checks passed
@mzihlmann mzihlmann deleted the cg188-secret-mounts branch November 30, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] --secret mounts for image builds

2 participants