Issue 827, handle large file rotation#2201
Merged
Merged
Conversation
Signed-off-by: Scott R. Shinn <scott@atomicorp.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #827 by enabling large-file support across the build so that components like ossec-monitord can handle/compress log archives larger than 2–4GB correctly on 32-bit/off_t-limited environments.
Changes:
- Enable 64-bit file offsets at compile time via
_FILE_OFFSET_BITS=64and_LARGEFILE64_SOURCEin the main build defines. - Standardize crypto module includes to use
headers/shared.h, ensuring consistent feature macros and common headers are applied early.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/os_crypto/sha1/sha1_op.c |
Switches to headers/shared.h to centralize/standardize large-file and common includes. |
src/os_crypto/md5/md5_op.c |
Switches to headers/shared.h for consistent common headers and macros. |
src/os_crypto/md5_sha1/md5_sha1_op.c |
Switches to headers/shared.h to align with shared large-file/common-header setup. |
src/Makefile |
Adds large-file feature macros (_FILE_OFFSET_BITS=64, _LARGEFILE64_SOURCE) to global build defines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #827