fix: only generate one VEX/SBOM/intermediate file per run#5731
Open
fix: only generate one VEX/SBOM/intermediate file per run#5731
Conversation
With
cve-bin-tool with --format csv,html --vex-output result.vex.json --revision-reason 'test'
We currently get two files:
- 1_result.vex.json
- result.vex.json
with result.vex.json having two metadata.properties entries:
"metadata": {
"timestamp": "2026-04-10T12:02:53Z",
"tools": {
"components": [
{
"name": "lib4vex",
"version": "0.2.3",
"type": "application"
}
]
},
"properties": [
{
"name": "Revision_1",
"value": "Test"
},
{
"name": "Revision_2",
"value": "Test"
}
],
result1.vex.json only has one.
This makes sure that regardless of the amount of different reports to
generate in one run, only one VEX file is generated, and only adding one
revision. This is done by decoupling output report generation from VEX,
intermediate and SBOM generation (which aren't related to the kind of
output report to generate).
Fixes: ossf#5686.
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Collaborator
|
@anthonyharrison, do you agree with the proposed change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
cve-bin-tool with --format csv,html --vex-output result.vex.json --revision-reason 'test'
We currently get two files:
with result.vex.json having two metadata.properties entries:
result1.vex.json only has one.
This makes sure that regardless of the amount of different reports to generate in one run, only one VEX file is generated, and only adding one revision. This is done by decoupling output report generation from VEX, intermediate and SBOM generation (which aren't related to the kind of output report to generate).
Fixes: #5686.
Cc @mmind