fix: stop leaking GITHUB_TOKEN in CI script tracing#282
Merged
Conversation
The CI helper script enables shell tracing globally and writes GITHUB_TOKEN into a temporary config file via heredoc. With tracing left on, the expanded token value can appear in workflow logs. Disable tracing only around the config-generation block so secret values are not echoed while preserving the rest of the script's trace output.
jmeridth
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI helper script writes a temporary config file that includes
GITHUB_TOKENwhile shell tracing is enabled. That allows the expanded token value to appear in local or workflow logs.This change disables tracing only around the config-generation block so the token is not echoed, while keeping the rest of the script's trace output intact.