-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data.yaml with runsafe #98
Conversation
Signed-off-by: jeffn-runsafe <[email protected]>
Signed-off-by: jeffn-runsafe <[email protected]>
Hello @jeffn-runsafe thank you for you contribution. Can you please put your Summery in |
Hi Marius - sorry, I think I need some help with this. Not an engineer, so
definitely not good with GitLab.
I realized the name contains "slashes" with C/C++, which may make it hard
to match the name to the logo. Any recommendation?
…On Wed, Mar 12, 2025 at 4:49 PM Marius Biebel ***@***.***> wrote:
Hello @jeffn-runsafe <https://github.com/jeffn-runsafe> thank you for you
contribution. Can you please put your Summery in '' so it's escaped
correctly? And your URL currently has "https://" twice. And if you like
we would love if you add your Logo to the catalog in the
SBOM-Catalog/public/logos directory as .png file.
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BK4GXFG4LRX3TOCW2K3FGZL2UCMVHAVCNFSM6AAAAABY4RVKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJZGA4TEMZTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: Mariuxdeangelo]*Mariuxdeangelo* left a comment
(ossf/sbom-everywhere#98)
<#98 (comment)>
Hello @jeffn-runsafe <https://github.com/jeffn-runsafe> thank you for you
contribution. Can you please put your Summery in '' so it's escaped
correctly? And your URL currently has "https://" twice. And if you like
we would love if you add your Logo to the catalog in the
SBOM-Catalog/public/logos directory as .png file.
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BK4GXFG4LRX3TOCW2K3FGZL2UCMVHAVCNFSM6AAAAABY4RVKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJZGA4TEMZTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: jeffn-runsafe <[email protected]>
I put the summary in |
@jeffn-runsafe no worries. I can fix it while merging later. Only thing, do you want to add a logo or go without? |
Signed-off-by: jeffn-runsafe <[email protected]>
Signed-off-by: jeffn-runsafe <[email protected]>
Signed-off-by: jeffn-runsafe <[email protected]>
Signed-off-by: jeffn-runsafe <[email protected]>
Signed-off-by: jeffn-runsafe <[email protected]>
Signed-off-by: jeffn-runsafe <[email protected]>
I added a logo runsafe-security.png Let me know if that works! |
@jeffn-runsafe so far everything is good. Only one thing, the catalog uses the name to resolve the logos. And i cant use special characters in a path. So is it of if i remove the C/C++ in the name? I think it is still quite clear were you tools abilities are located. |
Signed-off-by: Marius Biebel <[email protected]>
Yes that’s okay by me!
…On Wed, Mar 12, 2025 at 5:41 PM Marius Biebel ***@***.***> wrote:
@jeffn-runsafe <https://github.com/jeffn-runsafe> so far everything is
good. Only one thing, the catalog uses the name to resolve the logos. And i
cant use special characters in a path. So is it of if i remove the C/C++ in
the name? I think it is still quite clear were you tools abilities are
located.
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BK4GXFEQJVZU4T7T4MGSEXT2UCSXTAVCNFSM6AAAAABY4RVKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJZGE4TGOBZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: Mariuxdeangelo]*Mariuxdeangelo* left a comment
(ossf/sbom-everywhere#98)
<#98 (comment)>
@jeffn-runsafe <https://github.com/jeffn-runsafe> so far everything is
good. Only one thing, the catalog uses the name to resolve the logos. And i
cant use special characters in a path. So is it of if i remove the C/C++ in
the name? I think it is still quite clear were you tools abilities are
located.
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BK4GXFEQJVZU4T7T4MGSEXT2UCSXTAVCNFSM6AAAAABY4RVKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJZGE4TGOBZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Great, @joshbressers can you approve the pull request. I have contributed commits to this pr so i can't approve it allown. The we can deploy it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment
@jeffn-runsafe i merged and published this in the PR #101. Its already deployed. I will close this one. Thanks again for reaching out. |
No description provided.