Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data.yaml with runsafe #98

Closed
wants to merge 10 commits into from
Closed

Conversation

jeffn-runsafe
Copy link
Contributor

No description provided.

Signed-off-by: jeffn-runsafe <[email protected]>
@Mariuxdeangelo
Copy link
Collaborator

Hello @jeffn-runsafe thank you for you contribution. Can you please put your Summery in '' so it's escaped correctly? And your URL currently has "https://" twice. And if you like we would love if you add your Logo to the catalog in the SBOM-Catalog/public/logos directory as .png file.

@jeffn-runsafe
Copy link
Contributor Author

jeffn-runsafe commented Mar 12, 2025 via email

Signed-off-by: jeffn-runsafe <[email protected]>
@jeffn-runsafe
Copy link
Contributor Author

I put the summary in '' and removed the slash from the title

@Mariuxdeangelo
Copy link
Collaborator

@jeffn-runsafe no worries. I can fix it while merging later. Only thing, do you want to add a logo or go without?

@jeffn-runsafe
Copy link
Contributor Author

I added a logo runsafe-security.png

Let me know if that works!

@Mariuxdeangelo
Copy link
Collaborator

@jeffn-runsafe so far everything is good. Only one thing, the catalog uses the name to resolve the logos. And i cant use special characters in a path. So is it of if i remove the C/C++ in the name? I think it is still quite clear were you tools abilities are located.

Signed-off-by: Marius Biebel <[email protected]>
@jeffn-runsafe
Copy link
Contributor Author

jeffn-runsafe commented Mar 12, 2025 via email

@Mariuxdeangelo
Copy link
Collaborator

Great, @joshbressers can you approve the pull request. I have contributed commits to this pr so i can't approve it allown. The we can deploy it.

@joshbressers
Copy link
Contributor

I'm going to approve this in case it's just my instance that's busted. But the logo I see in the circle view has a black circle for this (the list view works, and when I click on the black circle I see the correct logo on the right)

image

Copy link
Contributor

@joshbressers joshbressers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment

@Mariuxdeangelo
Copy link
Collaborator

@jeffn-runsafe i merged and published this in the PR #101. Its already deployed. I will close this one. Thanks again for reaching out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants