Enable support for OpenSSF Badges instead of only scores - #46
Merged
Conversation
Member
|
@rajbos I think the key in this case is to replace |
rajbos
force-pushed
the
main
branch
2 times, most recently
from
March 26, 2023 18:25
ad75770 to
9808a25
Compare
Contributor
Author
|
Ah check. That fixed it. Marking this as ready for review 😄. |
rajbos
marked this pull request as ready for review
March 26, 2023 18:27
UlisesGascon
requested changes
Mar 28, 2023
UlisesGascon
left a comment
UlisesGascon
left a comment
Member
There was a problem hiding this comment.
Just a minor thing, @rajbos .. can you remove the .github/workflows/test_action_locally.yml file from this PR and create a separate PR for that file. I love to discuss about it in more detail but I don't want to block this PR as the Badge logic is perfect for being shipped in the next Beta release 🎉
Contributor
Author
|
Sure, I've removed the file and force pushed again 😃. Another PR for the workflow has been created: #51. |
UlisesGascon
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
Leaving this in draft for now, as I still need to add the new param to the README.
But maybe you can help me out here: I cannot find why the test fails on this space. Even adding an extra space in front of the IF statement in the template, does not do a thing (there is already a space). I have never used this library for templating, so hopefully you know how and where this happens :-).