Skip to content

✨ Specific error message for branch protection permission failure. #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kash2104 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Specific error message for branch protection permission failure. #4892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clients/githubrepo/branches.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@
// Ignore permissions errors if we know the repository is using rulesets, so non-admins can still get a score.
queryData := new(branchData)
if err := handler.graphClient.Query(handler.ctx, queryData, vars); err != nil {
if strings.Contains(err.Error(), "resource not accessible by integration") {
return nil, sce.WithMessage(sce.ErrScorecardInternal, "Branch protection failed.Default token insufficient.Use PAT.")

Check warning on line 315 in clients/githubrepo/branches.go

View check run for this annotation

Codecov / codecov/patch

clients/githubrepo/branches.go#L314-L315 

Added lines #L314 - L315 were not covered by tests
}
// always report errors which aren't token permission related
if !isPermissionsError(err) {
return nil, sce.WithMessage(sce.ErrScorecardInternal, fmt.Sprintf("githubv4.Query: %v", err))
Expand Down
Loading