prepare-root: Don't hardcode sysroot#3447
Merged
Merged
Conversation
Follow to previous change to factor out composefs mounting; prep for soft reboots. Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| return TRUE; | ||
|
|
||
| const char *objdirs[] = { "/sysroot/ostree/repo/objects" }; | ||
| g_autofree char *sysroot_objects = g_strdup_printf ("%s/ostree/repo/objects", root_mountpoint); |
There was a problem hiding this comment.
Consider using g_build_filename() instead of g_strdup_printf() for constructing file paths. g_build_filename() correctly handles path separators, preventing potential issues like double slashes if root_mountpoint has a trailing slash.
g_autofree char *sysroot_objects = g_build_filename (root_mountpoint, "ostree", "repo", "objects", NULL);
jmarrero
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow to previous change to factor out composefs mounting; prep for soft reboots.