multiple CI fixes#3599
Conversation
strrchr() returns a 'const char *' when passed a 'const char *' argument. Declare the local 'slash' variable as 'const char *' to match, fixing a build failure with clang when -Werror,-Wincompatible-pointer-types-discards-qualifiers is active. Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
In _ostree_delta_get_endianness, total_usize was accumulated across delta parts but never read or used in any heuristic or output. Remove the dead variable and its accumulation.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up unused variables and improves const-correctness. Specifically, it removes the unused variable 'total_usize' in 'ostree-repo-static-delta-core.c' and updates 'slash' to be a 'const char *' in 'ostree-trivial-httpd.c'. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This allows dependency resolution to handle soname changes (e.g. gpgme 1.x to 2.x) instead of silently installing mismatched libraries.
The builder and coreos-assembler images may ship different library versions (e.g. gpgme), causing soname mismatches at runtime. Use RPM overrides for cosa and dnf for the container itself.
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Ideally in the future we do the "build derived container" instead of the cosa flow
|
@jmarrero: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Let's just drop Prow. I want to get to a world where we only have GHA and Konflux as the main things we care about. To drop it, we can basically make it a no-op to start, I think just have the Dockerfile be say |
|
4 participants
This picks up #3594 to fix prow failures and #3579 to fix Rust / build-git-libostree