Skip to content

[HTML Report] If any of the child nodes fails, the parent node shows a failure - #1095

Open
javier-sanchez-klarrio wants to merge 2 commits into
ota4j-team:mainfrom
klarrio-oss:html-report-reflect-child-status
Open

[HTML Report] If any of the child nodes fails, the parent node shows a failure #1095
javier-sanchez-klarrio wants to merge 2 commits into
ota4j-team:mainfrom
klarrio-oss:html-report-reflect-child-status

Conversation

@javier-sanchez-klarrio

Copy link
Copy Markdown

This is reproducing the same behaviour typically show in IDEs and other test reports.

Given parent test class A with test methods a,b,c,d. If any of a,b,c,d fail then the status of A is shown as failed.
In case none of the child tests fail but any is skipped/disabled, the overall status of the parent node(s) is still marked as success.

I did not see any tests in the html-report project, here's an example from an extended version of the sample-project:

image

Please let me know if i should do anything differently!

@marcphilipp

Copy link
Copy Markdown
Member

Thanks for the PR! I understand why you'd want this behavior. However, I didn't want to stray too far from what is reported in the original file. A toggle button in the toolbar would be a way forward to have both. WDYT?

@javier-sanchez-klarrio

javier-sanchez-klarrio commented Jun 30, 2026

Copy link
Copy Markdown
Author

Thanks for the PR! I understand why you'd want this behavior. However, I didn't want to stray too far from what is reported in the original file. A toggle button in the toolbar would be a way forward to have both. WDYT?

Thank you for creating this project!

Do you mean a toggle to switch between the current behaviour and that of this PR?
should that be placed next to the existing filter buttons?

@marcphilipp

Copy link
Copy Markdown
Member

Maybe to the left and with a separator?

@mpkorstanje

mpkorstanje commented Jun 30, 2026

Copy link
Copy Markdown
Member

However, I didn't want to stray too far from what is reported in the original file.

@marcphilipp, why not? The different formats are for different audiences. And with that in mind, if a toggle is introduced, then it would make sense for it to default to on otherwise it might appear that failed tests are hidden when collapsing a node.

@marcphilipp

Copy link
Copy Markdown
Member

The different formats are for different audiences.

I'm not fully convinced that's the case but I could live with the toggle being in "aggregated" mode by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants