Skip to content

Safari 11 bugfix: usage of promise-based version for pc.createOffer #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Safari 11 bugfix: usage of promise-based version for pc.createOffer #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rtcpeerconnection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ PeerConnection.prototype.offer = function (constraints, cb) {
if (this.pc.signalingState === 'closed') return cb('Already closed');

// Actually generate the offer
this.pc.createOffer(
this.pc.createOffer( mediaConstraints ).then(
function (offer) {
// does not work for jingle, but jingle.js doesn't need
// this hack...
Expand Down Expand Up @@ -444,8 +444,7 @@ PeerConnection.prototype.offer = function (constraints, cb) {
function (err) {
self.emit('error', err);
cb(err);
},
mediaConstraints
}
);
};

Expand Down