Skip to content

Windows junction handling for Go 1.23+ #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nusiq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Windows junction handling for Go 1.23+ #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion copy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func switchboard(src, dest string, info os.FileInfo, opt Options) (err error) {
}

switch {
case info.Mode()&os.ModeSymlink != 0:
case info.Mode()&os.ModeSymlink != 0 || info.Mode()&os.ModeIrregular != 0:
Copy link
Copy Markdown
Owner

@otiai10 otiai10 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just adding another case?

Copy link
Copy Markdown
Author

@Nusiq Nusiq Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, It's your code. If the junctions are handled the same way as symlinks the result is the same. I'm not sure if they require any special handling so I put it in one case.

err = onsymlink(src, dest, opt)
case info.IsDir():
err = dcopy(src, dest, info, opt)
Expand Down
Loading