Repository navigation
fix(kiritan): keep front matter first in the fallback sidecar, and match kiritan:hash strictly - #55
Merged
Conversation
…atch kiritan:hash only in the renderer's own comment syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #49 and #50, from Copilot's review of #49 plus my own re-review.
<!-- kiritan:untranslated ... -->before the source, so a source starting with front matter was no longer parsed as front matter and its metadata could be interpolated/reformatted. The marker now goes after the front matter. There is an integration test throughbuild.extractHashCommentmatchedkiritan:hash <hex>anywhere, so the same words in prose or a code sample could be read as a marker and flag a translation as stale. The pattern is now derived from the renderer's owncomment(HTML comment for Markdown,{/* */}for MDX), andcheck/translatepass it in.Why?
Both are regressions that came in with the front matter and renderer work.
Related issue(s)
closes
Check
CONTRIBUTING.md(rules)npm run check(lint & format)npm run typechecknpm run test(functions test)npm run build(dist/)npm run test:coverageand check nothing new went uncovered