fix(cli): validate deploy program id keypair match#4694
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
|
@fallintoplace is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
0x4ka5h
previously approved these changes
Jun 22, 2026
0x4ka5h
left a comment
0x4ka5h
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, fixes a real deploy correctness bug
jamie-osec
reviewed
Jun 22, 2026
fallintoplace
force-pushed
the
fix/program-id-keypair-assertion
branch
from
c543c9a to
8d0ac72
Compare
0x4ka5h
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--program-idas an assertion whenanchor program deployalso receives--program-keypair.--program-idwithout--program-keypairand add focused tests for both cases.Why
The native deploy path loaded the requested program keypair and then unconditionally used that keypair pubkey as the target program ID. That meant a command with
--program-id X --program-keypair Ysilently targetedY, even if the user was expectingX.Validation
cargo fmt --package anchor-clicargo test -p anchor-cli program_idcargo test -p anchor-cli program::tests::