fix(client): reject non-http custom cluster URL schemes#4741
Open
blackflytech wants to merge 2 commits into
Open
fix(client): reject non-http custom cluster URL schemes#4741blackflytech wants to merge 2 commits into
blackflytech wants to merge 2 commits into
Conversation
Signed-off-by: blackflytech <blackflytech@outlook.com>
blackflytech
requested review from
chen-robert,
jamie-osec and
renato-osec
as code owners
|
@blackflytech is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
0x4ka5h
previously approved these changes
Jun 30, 2026
jamie-osec
reviewed
Jun 30, 2026
Signed-off-by: blackflytech <blackflytech@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cluster::from_strpreviously accepted any custom URL whose input started withhttp, which allowed non-HTTP(S) schemes such ashttpx://...to be parsed as custom RPC URLs and converted into websocket URLs.This change tightens the custom cluster URL check to only accept
http://andhttps://prefixes. The comparison uses the lowercased input, so valid uppercase schemes likeHTTPS://...continue to work.Regression tests cover both rejecting a non-HTTP scheme with an
httpprefix and accepting an uppercase HTTPS scheme.Branch Target
If this contains breaking changes, it should target the
anchor-nextbranch.