Conversation
Deploying rctf with
|
| Latest commit: |
8d1f171
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2792ca3.rctf.pages.dev |
| Branch Preview URL: | https://feat-e2e.rctf.pages.dev |
trixter-osec
previously approved these changes
Oct 31, 2025
Collaborator
trixter-osec
left a comment
trixter-osec
left a comment
There was a problem hiding this comment.
See the comments left, otherwise LGTM. You probably should also document running E2E tests in CONTRIBUTING.md as right now they're very environment-specific.
Some things that would make sense to implement eventually in the future:
- Have separate environment in which E2E tests run in, with pre-seeded data. This way you can get more value out of the tests as for example in scoreboard tests you can actually check that the correct teams are displayed (other than "something happens")
- integrate E2E with CI
es3n1n
approved these changes
Nov 1, 2025
Collaborator
es3n1n
left a comment
es3n1n
left a comment
There was a problem hiding this comment.
I don't think i have much to add. As for the pre-seeded environment for the e2e tests, I think the reasonable approach would be to have a separate script that will set things up in a specific way on start (and maybe tear things down once its done), probably something we should look into in the future.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added e2e tests using Playwright
Improved admin page UI