Fix ExternalName service handling and add standardized owner kind mappings #600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ExternalName Service Fix (4 API versions)
ServiceIdentityToLabelsForWorkloadSelectionin v1alpha3, v1beta1, v2alpha1, v2beta1(nil, false, nil)instead of throwing "service has no selector" errorStandardized Owner Kind Mappings
Workflow→argo-workflow: Consistent identity for Argo Workflow podsSparkApplication→spark: Groups Spark driver and executor podsRunnerDeployment→actions-runner: Consistent identity for GitHub Actions runnersServiceowners now include API group to prevent naming conflictsTest Coverage
Added 5 new test cases in
serviceidresolver_test.go:TestServiceIdentityToPodLabelsForWorkloadSelection_ServiceKind_ExternalNameServiceTestResolvePodToServiceIdentity_WorkflowOwnerTestResolvePodToServiceIdentity_SparkApplicationOwnerTestResolvePodToServiceIdentity_RunnerDeploymentOwnerTestResolvePodToServiceIdentity_ServiceOwnerAll tests pass successfully.
Test plan
go test ./shared/serviceidresolver/... -vgo fmt🤖 Generated with Claude Code