introduce snapshot testing for the chart #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlandowner
force-pushed
the
snapshot-testing
branch
from
101325d to
4d6d69c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Hi, thank you for the useful and stable chart.
I would like to introduce snapshot testing for the chart project.
It allows to you to detect any change of the chart for common usecases.
You can check the impact on common usecases on Git before release.
Here is the examples.
Confirm not to break any existing feature.
Detect a broken change.
Update the snapshots by a single command
This way is adopted in Kong chart project. https://github.com/Kong/charts/tree/main/charts/kong/ci
It is also good to do snapshot testing in CI but it's not in this PR so far (but Kong does!)
ref:
https://github.com/Kong/charts/blob/main/.github/workflows/release-pr.yaml#L208
https://github.com/Kong/charts/blob/main/Makefile#L70
Please feel free to try it!
Checklist:
artifacthub.io/changesannotation in Chart.yml according to the documentation