refactor: Separate application port from service port #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Gentoli Could you also introduce the ability to update Ollama env variable Currently the variable is defined in the docker file as follow: ENV OLLAMA_HOST=0.0.0.0:11434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Add
.Values.ollama.portto track ollama port.This allows
another pod -(svc.cluster.local:80)-> Service -(select by port name 'http=11434')-> Ollama pod. Changingservice.portin this case will cause the the service forward traffic to port 80 on ollama.Checklist:
artifacthub.io/changesannotation in Chart.yml according to the documentation