Fix folder references for post start hooks on using custom model templates #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a helm pro here by any means but I believe the ollama.modelsMountPath is missing a condition to check when the mountPath has been changed thereby affecting postStart hooks in the ollama.create functionality.
ollama-helm/templates/deployment.yaml
Line 183 in c71a862
ollama-helm/templates/deployment.yaml
Line 123 in c71a862
Summary of changes:
Update _helpers.tpl file to respect custom mountPaths when using ollama.create templates/modelfiles.
Update deployment.yaml to retrieve same variable value
Update Chart.yaml per PR requirements.
Please let me know if I need to change anything here - I was able to run this locally against my desired chart values (with custom templates + non root) - thanks
Checklist:
artifacthub.io/changes
annotation in Chart.yml according to the documentation