fix: ignore invalid unix permissions and setuid bits from zip#1007
Merged
Conversation
Signed-off-by: tommady <tommady@users.noreply.github.com>
Collaborator
Author
|
hi @marcospb19 please review while you have time. |
marcospb19
requested changes
Jun 21, 2026
marcospb19
left a comment
marcospb19
left a comment
Member
There was a problem hiding this comment.
Looking good, can you take a look at the new conflicts?
Member
|
Hey, PR #951 will be merged before this one. In the description there is this item: Setuid/setgid bits from zip entries are preserved on extraction. 👁️ 👁️ so, maybe it will clash with this PR too and cause more conflicts. |
Collaborator
Author
Member
|
Okay! #951 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1006
Some zip files created on MS-DOS environments store invalid attributes that
zipreads as unix modes missing the file type bits, resulting in unintended setuid permissions.In the reported issue,
statrevealed the file access mode was0o4032.In a valid Unix permission mode, the file type bits (
S_IFMT, e.g.,0o100000for a regular file) must be set.A mode of
0o4032entirely lacks these file type bits, meaning it is garbage data (likely MS-DOS attributes or arbitrary metadata from the archive generator) being mistakenly interpreted as a Unix mode.