Merged
Conversation
✅ Deploy Preview for ofh-design-system-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
febc546 to
a336ed9
Compare
464df9b to
7c90ea6
Compare
This reverts commit 762864c.
7c90ea6 to
1798ee7
Compare
This reverts commit 1798ee7.
df77a99 to
5f78649
Compare
This reverts commit 4f29fe2.
jones-2077
approved these changes
Dec 17, 2025
mwiercinska
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://ourfuturehealth.atlassian.net/browse/PC-294
This PR introduces Snyk scanning to the design-system-toolkit repository, replacing semgrep as recommended by @DionKontopodias
Other repos use the reusable action from the kondukto-scan repository for snyk scanning. But since the reusable action is in a private repository, we cannot directly use it in this repo which is public.
I don't have a very clear view on exactly what we are aiming for - this ticket was created because we saw the kondukto scan fail e.g here. In a thread and in some messages Dion seemed to suggest an approach like this which is what I've attempted to add
I've copied over the snyk-specific logic with a couple of changes: