DSE-326 / DSE-328 :: Details and Expander FE update#201
Merged
diogo-filipe-costa merged 6 commits intomainfrom Apr 20, 2026
Merged
DSE-326 / DSE-328 :: Details and Expander FE update#201diogo-filipe-costa merged 6 commits intomainfrom
diogo-filipe-costa merged 6 commits intomainfrom
Conversation
✅ Deploy Preview for ofh-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ofh-design-system-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the “details family” UI across the toolkit and docs site to match the latest Figma treatment, and introduces the first public React Details and Expander components built on a shared internal renderer to keep behaviour and styling aligned.
Changes:
- Refreshed toolkit
details/expandertemplates and SCSS for updated icon-state and spacing rules. - Added new public React
Details+Expandercomponents (tests + Storybook docs) backed by a shared internalDetailsFamilyBase. - Updated docs/upgrade/release documentation and version bumps for the
4.11.0/0.9.0release.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| UPGRADING.md | Adds upgrade entry for toolkit 4.11.0 and React 0.9.0. |
| packages/toolkit/package.json | Bumps toolkit version to 4.11.0. |
| packages/toolkit/components/details/template.njk | Aligns details/expander markup and icon rendering via shared template logic. |
| packages/toolkit/components/details/README.md | Updates docs examples/wording for refreshed details/expander markup. |
| packages/toolkit/components/details/_details.scss | Reworks details/expander styling for new spacing/icon-state rules. |
| packages/site/views/design-system/components/expander/index.njk | Refreshes component metadata “last updated” date. |
| packages/site/views/design-system/components/details/rich-content/index.njk | Adds a new docs-site rich-content example for Details. |
| packages/site/views/design-system/components/details/index.njk | Links in the new rich-content example and refreshes metadata date. |
| packages/react-components/src/index.ts | Exports new React Details and Expander public APIs. |
| packages/react-components/src/components/Expander/index.ts | Barrel export for Expander. |
| packages/react-components/src/components/Expander/Expander.tsx | Implements Expander via the shared internal renderer. |
| packages/react-components/src/components/Expander/Expander.test.tsx | Adds unit + a11y tests for Expander. |
| packages/react-components/src/components/Expander/Expander.stories.tsx | Adds Storybook stories including a “Grouped” example. |
| packages/react-components/src/components/Details/index.ts | Barrel export for Details. |
| packages/react-components/src/components/Details/Details.tsx | Implements Details via the shared internal renderer. |
| packages/react-components/src/components/Details/Details.test.tsx | Adds unit + a11y tests for Details. |
| packages/react-components/src/components/Details/Details.stories.tsx | Adds Storybook stories including rich-content example. |
| packages/react-components/src/components/_internal/DetailsFamily.tsx | Introduces shared internal renderer used by both new components. |
| packages/react-components/README.md | Updates install URL/version and documents new components in usage example. |
| packages/react-components/package.json | Bumps React components version to 0.9.0. |
| docs/release-versioning-strategy.md | Updates example tags/URLs and release table entries for new versions. |
| CHANGELOG.md | Adds release notes for toolkit 4.11.0 and React 0.9.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jpsanders101
approved these changes
Apr 17, 2026
2bdcb23 to
955aef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR delivers DSE-326 / DSE-328 details and expander refresh across toolkit, React, the docs site, and Storybook.
It aligns the details-family components with the current Figma patterns, updates toolkit and React coverage for both
DetailsandExpander, and brings Storybook into the newerDocs/Default/Builder/ showcase teaching pattern.Ticket: DSE-326 / DSE-328
Release scope
@ourfuturehealth/toolkit->4.11.0@ourfuturehealth/react-components->0.10.0CHANGELOG.md,UPGRADING.md,docs/release-versioning-strategy.md,docs/consuming-react-components.md, andpackages/react-components/README.mdBreaking Changes
Key Changes
DetailsandExpanderDetailsandExpandercomponentsDetailsfor lighter supporting informationExpanderfor more prominent expandable contentDefaultstories as realistic fixed examples,Builderstories as the interactive surface, and showcase stories as fixed usage examplesValidation
npm testpnpm lintpnpm buildpnpm docs:release-contractpnpm smoke:release-artifactspnpm --filter=@ourfuturehealth/react-components build:storybookReviewer Focus
DetailsandExpandershould both be aligned with the updated component worktoolkit-v4.11.0/react-v0.10.0