Skip to content

[Devops] Run metrics job from forks - #1113

Open
karl-richter wants to merge 21 commits into
ourownstory:mainfrom
karl-richter:metrics/from_fork
Open

[Devops] Run metrics job from forks#1113
karl-richter wants to merge 21 commits into
ourownstory:mainfrom
karl-richter:metrics/from_fork

Conversation

@karl-richter

@karl-richter karl-richter commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🔬 Background

  • Currently the metrics job does not run on forks due to issues with the CML library (comments from forks to the main repo are not supported).

🔮 Key changes

  • In a recent PR, the CML library introduced the feature to comment on pr's from forks.
  • This PR contains the change to comment from a fork to the target pr.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@karl-richter

karl-richter commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator Author

Closed #910

@codecov-commenter

codecov-commenter commented Jan 13, 2023 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.21%. Comparing base (4ea077a) to head (652f6d2).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files          41       41           
  Lines        5355     5355           
=======================================
  Hits         4724     4724           
  Misses        631      631

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karl-richter karl-richter changed the title run metrics job from a fork Run metrics job from a fork Jan 13, 2023
@karl-richter karl-richter changed the title Run metrics job from a fork Run metrics job from forks Jan 13, 2023
@karl-richter karl-richter self-assigned this Jan 13, 2023
@karl-richter karl-richter added the type:bug Something isn't working label Jan 30, 2023
@noxan noxan mentioned this pull request Feb 28, 2023
Merged
3 tasks
@noxan noxan added the status: in development Pull requests which are in development label Mar 1, 2023
@karl-richter karl-richter added status: blocked and removed status: in development Pull requests which are in development labels Mar 15, 2023
@karl-richter
karl-richter marked this pull request as ready for review May 15, 2023 14:54
@karl-richter

karl-richter commented May 15, 2023

Copy link
Copy Markdown
Collaborator Author

Note: This pr does not fully fix the problem of the metrics job failing when executed from a forked repository. Github requires the agent to be logged in when commenting on pull requests of another repository. However, this pr provides a cleaner implementation of commenting to pull requests when executed from a branch within the main repository. Therefore I would recommend to merge this pr now and create a seperate pr when the metrics job should also succeed in forked repositories.

@ourownstory ourownstory mentioned this pull request Oct 18, 2023
Merged
@ourownstory ourownstory changed the title Run metrics job from forks [Devops] Run metrics job from forks Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@karl-richter karl-richter

Labels

status: blocked type:bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karl-richter @codecov-commenter @noxan @ourownstory