[refactor] Update python-holidays integration

[arkid15r]

🔬 Background

Resolves #295

🔮 Key changes

• Bump python-holidays version to 0.20.
• Migrate to python-holidays as a single source of country holidays.

📋 Review Checklist

• I have performed a self-review of my own code.
• I have commented my code, added docstrings and data types to function definitions.
• I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

[codecov-commenter]

Codecov Report

Merging #1176 (e029657) into main (5770171) will decrease coverage by 0.71%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1176      +/-   ##
==========================================
- Coverage   90.20%   89.49%   -0.71%     
==========================================
  Files          36       35       -1     
  Lines        5145     4770     -375     
==========================================
- Hits         4641     4269     -372     
+ Misses        504      501       -3     

Impacted Files	Coverage Δ
neuralprophet/hdays_utils.py	100.00% <100.00%> (+16.66%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ourownstory]

@arkid15r Wonderful, thank you so much for upgrading holidays with the needed countries and for updating our use of holidays, including tests.
Much appreciated!

[arkid15r]

@arkid15r Wonderful, thank you so much for upgrading holidays with the needed countries and for updating our use of holidays, including tests. Much appreciated!

Hi @ourownstory,
thanks for the quick reply!

I'm not sure whether it's safe to merge the PR? Those failing metrics and windows tests jobs look a bit concerning.

[noxan]

LGTM, thanks for the awesome contribution @arkid15r 👏

Edit: oh didn't see your review @ourownstory :)

[noxan]

@arkid15r Those are (sadly) known issues: windows tests failing are tracked in #991 and the metrics do not work on forks #1113 - so I'll go ahead and merge it

[github-actions]

Model Benchmark

Benchmark	Metric	main	current	diff
YosemiteTemps	MAE_val	1.72949	1.72948	-0.0%	✅
YosemiteTemps	RMSE_val	2.27386	2.27386	-0.0%	✅
YosemiteTemps	Loss_val	0.00096	0.00096	-0.0%	✅
YosemiteTemps	MAE	1.45189	1.45189	-0.0%	✅
YosemiteTemps	RMSE	2.16631	2.16631	-0.0%	✅
YosemiteTemps	Loss	0.00066	0.00066	0.0%	✅
YosemiteTemps	time	151.017	167.6	10.98%	❌
AirPassengers	MAE_val	15.4077	15.4077	0.0%	✅
AirPassengers	RMSE_val	19.5099	19.5099	0.0%	✅
AirPassengers	Loss_val	0.00196	0.00196	0.0%	✅
AirPassengers	MAE	9.86947	9.86947	-0.0%	✅
AirPassengers	RMSE	11.7222	11.7222	-0.0%	✅
AirPassengers	Loss	0.00057	0.00057	-0.0%	✅
AirPassengers	time	5.6505	7.41	31.14%	❌
PeytonManning	MAE_val	0.64636	0.64636	-0.0%	✅
PeytonManning	RMSE_val	0.79276	0.79276	-0.0%	✅
PeytonManning	Loss_val	0.01494	0.01494	-0.0%	✅
PeytonManning	MAE	0.42701	0.42701	0.0%	✅
PeytonManning	RMSE	0.57032	0.57032	-0.0%	✅
PeytonManning	Loss	0.00635	0.00635	0.0%	✅
PeytonManning	time	15.509	21.1	36.05%	❌

Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers