[Minor] Add function to retrieve regressor coefficients - #1597
[Minor] Add function to retrieve regressor coefficients#1597weberpals wants to merge 11 commits into
Conversation
ourownstory
left a comment
There was a problem hiding this comment.
Thank you Constantin!
It is looking good overall!
You are headed in the right direction - I added some comments on how you can address some issues regarding the coefficient computation.
Please also add one or more tests covering your new functionality, a micro example in the docstring, and add a short feature-guide notebook demonstrating the use of your method.
There was a problem hiding this comment.
Thank you for upgrading the coefficient computation!
I left few small comments in the review. Beyond, Do you mind adding:
- Please also add one or more tests covering your new functionality,
- a micro example in the docstring,
- and add a short feature-guide notebook demonstrating the use of your method (both directly, and indirectly via the plotting methods).
- Please also look into the existing plotting code and make sure that that code uses your code for visualizing coefficients in plots. Please also make sure that if your code yields different results (compared to the existing plotting code; likely), that those differences are intentional/meaningful (also likely).
|
Thanks for the feedback! I wasn't aware that some of the weight calculations were already available and used in the plotting function. I adapted the functions to integrate cleaner with the existing code. |
🔬 Background
🔮 Key changes
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.