Skip to content
This repository was archived by the owner on Dec 23, 2024. It is now read-only.

Conversation

@almndbtr
Copy link
Contributor

@almndbtr almndbtr commented Mar 1, 2022

Description

Towards #125 as a part of the Community Audit.

Motivation and Context

When a collection offer is settled, there are payouts to these respective parties:

  • Royalty Payout
  • Protocol Fee (optional)
  • Finders Fee (optional)

The integration tests cover the Royalty Payout case and the Optional Finders fee, but not the optional Protocol Fee.

This adds new assertions to the Collection Offers v1.0 integration tests when the protocol fee is 1 basis point (bps), the equivalent of 0.01%.

I chose this number based on the existing assertions defined in test/auxiliary/ZoraProtocolFeeSettings.t.sol.

How has this been tested?

In my development environment, I ran yarn test and confirmed all tests pass before opening this PR.

Checklist:

  • The module includes tests written for Foundry
  • The module is documented with NATSPEC
  • The documentation includes UML Diagrams for external and public functions
  • The module is a Hyperstructure

Reviewer Notes 👓

This takes the same approach as its sibling PR in #140 👯‍♀️

@kulkarohan kulkarohan merged commit 04f674b into ourzora:collection-offers Mar 3, 2022
@almndbtr almndbtr deleted the collection-offers-nonzero-protocol-fee branch March 3, 2022 01:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants