fix spelling issues protocol-sdk.mdx #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainnash
approved these changes
May 23, 2025
pull bot
pushed a commit
to Hawthorne001/zora-protocol
that referenced
this pull request
Jul 14, 2025
* rename mints to sparks * Sparks - when doing a transfer, if there is a `data` passed, then emit an event that includes that data (ourzora#505) This would allow us to include mint comments in that `data` field, and know that the comment was made by the executor of the transaction, or the signer of the permit message * Deployed Sparks contracts (ourzora#506) <!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## Does this change the ABI/API? - [ ] This changes the ABI/API <!-- If so, please describe how and what potential impact this may have --> ## What tests did you add/modify to account for these changes <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New module / feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I added a changeset to account for this change ## Reviewer Checklist: - [ ] My review includes a symposis of the changes and potential issues - [ ] The code style is enforced - [ ] There are no risky / concerning changes / additions to the PR * Sparks subgraph (ourzora#507) Copy of the mints subgraph, less mint comment * fix foundry config for file access * rename sparks unwrapper to eth unwrapper * added changeset * fix sparks impl address * fixed sparks proxy addresses * added a changeset * fix unwrapper * added changeset * fix subgraph deploys * dont lint wagmi generated * fix sparks rename * update version upgrades * use dynamic mint fee in test * deployed lowerSupply interface check * version bump subgraph so it matches whats deployed * clean up constructor * clean up changesets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/pages/changelogs/protocol-sdk.mdx
ambigious - ambiguous
migratring - migrating
defintions - definitions