Fix: Add username in socialAccounts response #525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the
socialAccountsresponse to include ausernamefield for each platform and added support for thefarcasterplatform.Motivation and Context
Needed to fetch actual
usernamesfrom Zora profiles for my app. The original response only haddisplayName, which isn’t usable for links or mentions. This update matches the Zora/profileAPI docs, which provide bothusernameanddisplayName.Update from:
{ "socialAccounts": { "instagram": { "displayName": "string" }, "tiktok": { "displayName": "string" }, "twitter": { "displayName": "string" } } }to
{ "socialAccounts": { "instagram": { "username": "string", "displayName": "string" }, "tiktok": { "username": "string", "displayName": "string" }, "twitter": { "username": "string", "displayName": "string" }, "farcaster": { "username": "string", "displayName": "string" } } }Does this change the ABI/API?
What tests did you add/modify to account for these changes
Types of changes
Checklist:
Reviewer Checklist: