Skip to content

Conversation

@0xaldric
Copy link
Contributor

@0xaldric 0xaldric commented Aug 4, 2025

Description

Updated the socialAccounts response to include a username field for each platform and added support for the farcaster platform.

Motivation and Context

Needed to fetch actual usernames from Zora profiles for my app. The original response only had displayName, which isn’t usable for links or mentions. This update matches the Zora /profile API docs, which provide both username and displayName.

Update from:

{
  "socialAccounts": {
    "instagram": {
      "displayName": "string"
    },
    "tiktok": {
      "displayName": "string"
    },
    "twitter": {
      "displayName": "string"
    }
  }
}

to

{
  "socialAccounts": {
    "instagram": {
      "username": "string",
      "displayName": "string"
    },
    "tiktok": {
      "username": "string",
      "displayName": "string"
    },
    "twitter": {
      "username": "string",
      "displayName": "string"
    },
    "farcaster": {
      "username": "string",
      "displayName": "string"
    }
  }
}

Does this change the ABI/API?

  • This changes the ABI/API

What tests did you add/modify to account for these changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New module / feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a changeset to account for this change

Reviewer Checklist:

  • My review includes a symposis of the changes and potential issues
  • The code style is enforced
  • There are no risky / concerning changes / additions to the PR

@iainnash
Copy link
Collaborator

iainnash commented Aug 6, 2025

Great fix thank you!

@iainnash iainnash self-requested a review August 8, 2025 18:34
@iainnash
Copy link
Collaborator

iainnash commented Aug 8, 2025

Can the types.gen.js file be removed? It's been automatically updated.

@0xaldric
Copy link
Contributor Author

0xaldric commented Aug 8, 2025

Can the types.gen.js file be removed? It's been automatically updated.

I removed, only updated profile.mdx file. Thanks

@faisalalbedwe
Copy link

I don't understand any thing
Can you help me please
I need your help

@iainnash iainnash merged commit 2a15288 into ourzora:main Aug 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants