Skip to content

Conversation

@jvaleskadevs
Copy link
Contributor

Description

Fix broken calls to createCoin.

  • The old code was throwing on factory address check.
  • Now it fallbacks to extract the address from the first parameter of the calldata (expecting an execute function) and check this extracted address against the hardcoded factory address.
  • It is done inside a nested conditional to keep the old code and maintain backwards compatibility. (I don't know if this is a need, may be better to just replace once check with the other?!)

Motivation and Context

Currently, the createCoin function throws:

Error: Creator coin is not supported for this SDK version

even when the transaction is a valid execute call to a valid factory address.

Does this change the ABI/API?

  • This changes the ABI/API

What tests did you add/modify to account for these changes

Patched and tested locally, deployed to production with patch-package on a different private project. Seems to be working fine again.

This package is building locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New module / feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a changeset to account for this change

Reviewer Checklist:

  • My review includes a symposis of the changes and potential issues
  • The code style is enforced
  • There are no risky / concerning changes / additions to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant