Upgrade AWS SAM deploy from Node.js v8.10 to v10.x#135
Open
jason-klein wants to merge 1 commit into
Open
Conversation
|
It is not possible anymore to create lambda with nodejs8.10, this should definitely be merged in order to keep AWS option.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node v8 reaches EOL 12/31/2019. AWS announced they will no longer allow customers to create new Node v8 functions beginning 01/06/2020.
The AWS Lambda runtime for Node v8 was named "nodejs8.10". The new Node v10 runtime is named "nodejs10.x". I successfully deployed and tested your slack-invite-automation code using the new Node 10 runtime for each of our local tech community Slack groups. Very simple update.
Thank you for continuing to maintain this package. We ❤️ the badge.svg feature because we can easily display active/total users from various local Slack groups. 😄