-
Notifications
You must be signed in to change notification settings - Fork 3k
@types/bun: deprecate some unused types especially on Bun
ns
#19145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more types that should be removed, I think the real fix for this is figuring out a more reliable way to detect these unused types.
Additionally could you please remove the symbols from bun.d.ts
that you added to deprecated.d.ts
, otherwise they are declared twice.
making changes. Also we can create a script or that can detect all unused types to deal with this in the future. |
Yeah, exactly. A script to detect these would be perfect. I'm not immediately sure how it would behave. Would need some investigation. |
Hi @alii I have addressed the comments and I am also am working on a script that auto detects unused types. I think the PR for the script should be a different one, also there are a few edgcases with the script that needs to be considered. For now / going forward we should probably add an eslint rule for unused types. |
1ebc358
to
e20566f
Compare
Cool, thanks! I agree, a lint rule would be nice. Currently busy with some work on the Bun website right now, but I will pull this branch and make sure everything works as expected later today. |
@alii Are you planning to merge this ? Also can you point out more good first issues that I can pick up. |
@Elusive7733 Looking through at the moment, couple of things I'll update myself on this (your) branch. We will/can probably merge this soon. Thanks again for the contributions. |
Bun
ns
What does this PR do?
Mark unused types as deprecated to improve type clarity and documentation:
How did you verify your code works?