Skip to content

configure ZLS build on save (disabled by default) #19223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

paperclover
Copy link
Collaborator

this is not good enough to enable by default. ZLS and the VSCode extension do not properly handle things.

to try what i have:

it is very finicky. i think there is room in the market for a new extension that only implements compile on save. this extension can focus on conveying status of the compilation into the editor, including progress bars and errors.

CleanShot_2025-04-23_at_11.20.21.mp4.mov

@robobun
Copy link

robobun commented Apr 23, 2025

Updated 12:46 PM PT - Apr 23rd, 2025

@paperclover, your commit dd4d165 has 2 failures in Build #15367:


🧪   try this PR locally:

bunx bun-pr 19223

@paperclover paperclover changed the title Chloe/zls configure ZLS build on save (disabled by default) Apr 23, 2025
@paperclover paperclover requested a review from 190n April 23, 2025 19:02
Copy link
Collaborator

@190n 190n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get it to work -- I had to hit "Build Workspace" each time after saving, and the errors stayed after I fixed them. I used your fork of zls and I changed build on save back to true in settings.json.

But merging this won't break anything, at least.

"-fincremental",
"-Dno-llvm",
"--global-cache-dir",
"./build/debug/zls-cache/g"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"./build/debug/zls-cache/g"
"./build/debug/zls-cache/g",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants