Add sourceMap to launch.json so lldb can find WebKit code #19263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 5:11 PM PT - May 9th, 2025
✅ @190n, your commit 85e96eda687a38796b135e9632ef1461517055ae passed in 🧪 To try this PR locally: bunx bun-pr 19263That installs a local version of the PR into your bun-19263 --bun |
Electroid
reviewed
Apr 24, 2025
| // Don't pause when the GC runs while the debugger is open. | ||
| "sourceMap": { | ||
| // macOS | ||
| "/Users/runner/work/_temp/webkit-release/vendor/WebKit": "${workspaceFolder}/vendor/WebKit", |
There was a problem hiding this comment.
Why are these needed? Feels like we're not passing the right flags to the WebKit build to make sources relative?
There was a problem hiding this comment.
Good point, I'll try some things in the WebKit repo. Looks like -fdebug-prefix-map may be it.
There was a problem hiding this comment.
I think for now this is still worth merging, though?
190n
requested review from
Electroid,
a team and
heimskr
and removed request for
a team
heimskr
previously approved these changes
Apr 30, 2025
pfgithub
previously approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes it easier to see WebKit source code in the debugger. For this to work you will need
vendor/WebKitto exist and be checked out at the right commit. I addedbun sync-webkit-sourceto make this easier.How did you verify your code works?
Ran a debugger on macOS and Linux with a breakpoint in
Zig::GlobalObject::visitChildrenImpl. With this change you can now pull up source for the WebKit functions that call that method: