fix test-webcrypto-random.js
#19264
Merged
fix test-webcrypto-random.js
#19264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 12:02 PM PT - May 8th, 2025
✅ @dylan-conway, your commit 9ad90e0f201704feef774c0f05e0b98b30f2d6be passed in 🧪 To try this PR locally: bunx bun-pr 19264That installs a local version of the PR into your bun-19264 --bun |
Jarred-Sumner
requested changes
Apr 25, 2025
Collaborator
Jarred-Sumner
left a comment
Jarred-Sumner
left a comment
There was a problem hiding this comment.
The validation for < 65 KB is breaking and unnecessary. I vote we skip that.
Member
Author
Removed the limit |
dylan-conway
requested review from
a team and
Jarred-Sumner
and removed request for
a team
cirospaciari
previously approved these changes
May 5, 2025
nektro
suggested changes
May 5, 2025
Contributor
nektro
left a comment
nektro
left a comment
There was a problem hiding this comment.
can you rerun ci before i approve? thats quite a few windows failures
nektro
approved these changes
May 8, 2025
cirospaciari
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Throws DOM exceptions for missing argument or if the argument isn't a buffer. Does not throw errors for buffers larger than 65kb or float buffers
How did you verify your code works?