implement --no-addons flag and "node-addons" export condition
#19530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 12:33 PM PT - May 8th, 2025
❌ @dylan-conway, your commit 3b776f9 has 1 failures in 🧪 To try this PR locally: bunx bun-pr 19530That installs a local version of the PR into your bun-19530 --bun |
dylan-conway
commented
May 7, 2025
| var transform_options = this.parent.transpiler.options.transform_options; | ||
|
|
||
| if (this.execArgv) |exec_argv| parse_new_args: { | ||
| var new_args: std.ArrayList([]const u8) = try .initCapacity(bun.default_allocator, exec_argv.len); |
Member
Author
There was a problem hiding this comment.
maybe we should convert the string impls to [] const []const u8 so we don't need to hold onto them. process.execArgv will cache the result, so this way we don't hold onto them in two places
Member
Author
There was a problem hiding this comment.
nvm, not doing this. parsing the new execArgv will only happen once
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
dylan-conway
requested review from
a team and
pfgithub
and removed request for
a team
pfgithub
approved these changes
May 8, 2025
cirospaciari
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes
test-no-addons-resolution-condition.jsHow did you verify your code works?
added a new test for throwing
ERR_DLOPEN_DISABLED