Skip to content

Conversation

@sosukesuzuki
Copy link
Member

Upgrade WebKit Jan 4, 2026 ( oven-sh/WebKit#124 ). Happy new year

- Update QueuedTask constructor calls to use new payload parameter
- BunPerformMicrotaskJob now handles async context directly (saves one argument slot)
- Replace SortedArrayMap usage with if-else chains (API changed in WTF)
- Fix typos: DOMEGCOutputConstraint -> DOMGCOutputConstraint
- Fix WTF_MAKE_TZONE_ALLOCATED macro argument in CryptoSignJob.h
- Update code generators (bindgen.ts, enumeration.ts) to not use SortedArrayMap

Claude-Generated-By: Claude Code (cli/claude-opus-4-5=100%)
Claude-Steers: 13
@robobun
Copy link
Collaborator

robobun commented Jan 4, 2026

Updated 10:50 PM PT - Jan 5th, 2026

@sosukesuzuki, your commit 2998923 has 99 failures in Build #34041 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 25821

That installs a local version of the PR into your bun-25821 executable, so you can run:

bun-25821 --bun

JSC parser automatically sets ImplementationVisibility to Private for async
functions that use await (see Parser.cpp line ~2281). The hand-rolled parser
in BuiltinExecutables.cpp uses the visibility value passed from generated
headers, so we need to match JSC's behavior here.

This fixes the 'm_implementationVisibility' mismatch (0 vs 1) that caused
assertion failures during debug builds after WebKit upgrade.

Claude-Generated-By: Claude Code (cli/claude-opus-4-5=100%)
Claude-Steers: 24
Removed loadAndEvaluateModule entries from error stack trace snapshot
as upstream WebKit changes no longer include them in output.

Claude-Generated-By: Claude Code (cli/claude-opus-4-5=100%)
Claude-Steers: 16
Claude-Permission-Prompts: 0
Claude-Escapes: 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants