forked from MetinSeylan/Nestjs-OpenTelemetry
-
Notifications
You must be signed in to change notification settings - Fork 1
Modernization of the package #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Helveg
wants to merge
58
commits into
overbit:main
Choose a base branch
from
Helveg:fork-modernization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6042b75.
…not classed as SERVER spans
… were loaded after the targeting lib i.e. graphql BREAKING CHANGE: the tracing SDK initialisation is now independent from the TracingModule
…trumentation-issues [BREAKING CHANGES] fix: issue related to missing some auto instrumentation tracing data
BREAKING CHANGES!
fix: add sync hello world test span fix: interceptor duration fix: lint fix : lint
BREAKING CHANGE: trigger semantic-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I think you're the latest in a string of forks, hopefully you're still maintaining it? This PR overhauls the package with the following improvements:
Dependency Modernization
Updated OTel dependencies for better compatibility.
0.x) but evolve quickly (current versions are around0.203while this package used0.49).<1to reduce version conflicts.Trace & Span Improvements
README & User Guidance
Developer-Oriented Changes
Updated package semantics to match modern OpenTelemetry conventions:
*Injectorclasses to*Instrumentation.Added
InterceptorInstrumentation.Created a
Tracerclass token to replace the previous interface, making it easier to inject.Fixed a bug with
useExistingproviders not working properly.