feat: use frontend-base compatibility layer#219
Closed
arbrandes wants to merge 2 commits into
Closed
Conversation
arbrandes
changed the title
arbrandes
force-pushed
the
arbrandes/frontend-base-compat
branch
4 times, most recently
from
May 4, 2026 14:23
8cf6dbc to
b4d288e
Compare
This was referenced May 4, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
Fix the light/dark mode toggle in the frontend-base site. (This breaks it in non-frontend-base sites. It's just here as a demonstration of what needs to be done.)
arbrandes
force-pushed
the
arbrandes/frontend-base-compat
branch
from
May 8, 2026 11:35
40c997c to
f10b036
Compare
Collaborator
|
closing this PR in favor of #220. Changes from this PR were cherry-picked there in the merged PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts each Indigo plugin slot configuration into a single
(slot_name, jsx)tuple constant and deduplicates the per-MFEPLUGIN_SLOTSentries by splatting those constants. The same constants are then registered withFRONTEND_COMPAT_SLOTSso the Indigo footer, theme switch buttons, mobile header, and themed logo also apply when running under frontend-base.This depends on overhangio/tutor-mfe#298.
LLM usage notice
Built with assistance from Claude.