Skip to content

fix: deduplicate custom_logo insert in logo_slot at runtime#222

Merged
Faraz32123 merged 1 commit into
releasefrom
ahmed/dedupe-custom-logo-runtime
May 14, 2026
Merged

fix: deduplicate custom_logo insert in logo_slot at runtime#222
Faraz32123 merged 1 commit into
releasefrom
ahmed/dedupe-custom-logo-runtime

Conversation

@ahmed-arb

Copy link
Copy Markdown
Contributor

Summary

  • When multiple insert operations target logo_slot with the custom_logo widget, MFEs render duplicate logos. This patch dedupes those inserts at runtime so only the first custom_logo insert survives.
  • Also sets keepDefault = false on logo_slot so the default logo content is suppressed when the slot is configured.

Test plan

  • Configure a deployment where logo_slot ends up with more than one custom_logo insert plugin (e.g. multiple plugins/slots stacking).
  • Verify only one logo renders in MFE headers and no duplicates appear.
  • Confirm single-insert deployments still render the expected logo unchanged.

🤖 Generated with Claude Code

@Faraz32123 Faraz32123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Faraz32123
Faraz32123 merged commit f4fc442 into release May 14, 2026
2 checks passed
@Faraz32123
Faraz32123 deleted the ahmed/dedupe-custom-logo-runtime branch May 14, 2026 05:56
@github-project-automation github-project-automation Bot moved this from Pending Triage to Done in Tutor project management May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants