fix: mfe config patch order#234
Merged
Merged
Conversation
ahmed-arb
reviewed
Jul 9, 2026
ahmed-arb
left a comment
Contributor
There was a problem hiding this comment.
This PR moves the Indigo MFE runtime configuration from the openedx-lms-common-settings patch file to plugin.py.
From this it sounds like moving file patch to plugin.py worked. But we're using a different patch in there. Moving the MFE settings to mfe-lms-common-settings file patch would have worked as well.
File patches and patches in plugin.py are same thing. File patches get injected to plugin.py. See this.
ahmed-arb
approved these changes
Jul 9, 2026
ahmed-arb
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please update the PR description now as well before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the Indigo MFE runtime configuration from the
openedx-lms-common-settingspatch file tomfe-lms-common-settings.Previously,
INDIGO_ENABLE_DARK_TOGGLEandINDIGO_FOOTER_NAV_LINKSwere assigned inopenedx-lms-common-settings. However,MFE_CONFIGis defined later by Tutor MFE, which could overwrite those assignments.By registering these settings through
mfe-lms-common-settings, the configuration is injected afterMFE_CONFIGhas been initialized.Testing
MFE_CONFIGis initialized.INDIGO_ENABLE_DARK_TOGGLEandINDIGO_FOOTER_NAV_LINKS.