Skip to content

fix: mfe config patch order#234

Merged
arbirali merged 2 commits into
releasefrom
mfe-config-order
Jul 9, 2026
Merged

fix: mfe config patch order#234
arbirali merged 2 commits into
releasefrom
mfe-config-order

Conversation

@arbirali

@arbirali arbirali commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR moves the Indigo MFE runtime configuration from the openedx-lms-common-settings patch file to mfe-lms-common-settings.

Previously, INDIGO_ENABLE_DARK_TOGGLE and INDIGO_FOOTER_NAV_LINKS were assigned in openedx-lms-common-settings. However, MFE_CONFIG is defined later by Tutor MFE, which could overwrite those assignments.

By registering these settings through mfe-lms-common-settings, the configuration is injected after MFE_CONFIG has been initialized.

Before After
development.py image development.py image

Testing

  • Verified the generated LMS settings include the Indigo configuration after MFE_CONFIG is initialized.
  • Verified the runtime configuration endpoint exposes INDIGO_ENABLE_DARK_TOGGLE and INDIGO_FOOTER_NAV_LINKS.
  • Confirmed the configuration is available to MFEs at runtime.

@arbirali arbirali self-assigned this Jul 9, 2026
@github-project-automation github-project-automation Bot moved this to Pending Triage in Tutor project management Jul 9, 2026
@arbirali
arbirali requested a review from ahmed-arb July 9, 2026 09:51

@ahmed-arb ahmed-arb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR moves the Indigo MFE runtime configuration from the openedx-lms-common-settings patch file to plugin.py.

From this it sounds like moving file patch to plugin.py worked. But we're using a different patch in there. Moving the MFE settings to mfe-lms-common-settings file patch would have worked as well.

File patches and patches in plugin.py are same thing. File patches get injected to plugin.py. See this.

@ahmed-arb ahmed-arb moved this from Pending Triage to In review in Tutor project management Jul 9, 2026
@arbirali
arbirali requested a review from ahmed-arb July 9, 2026 11:31

@ahmed-arb ahmed-arb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the PR description now as well before merging.

@arbirali
arbirali merged commit 0a592bd into release Jul 9, 2026
1 check passed
@arbirali
arbirali deleted the mfe-config-order branch July 9, 2026 11:56
@github-project-automation github-project-automation Bot moved this from In review to Done in Tutor project management Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants