feat: add docker-compose.prod.override.yml support#1221
Merged
DawoudSheraz merged 1 commit intooverhangio:releasefrom May 14, 2025
Merged
feat: add docker-compose.prod.override.yml support#1221DawoudSheraz merged 1 commit intooverhangio:releasefrom
DawoudSheraz merged 1 commit intooverhangio:releasefrom
Conversation
ahmed-arb
requested changes
May 5, 2025
ahmed-arb
approved these changes
May 5, 2025
DawoudSheraz
reviewed
May 6, 2025
| <!-- - [Improvement] This is a non-breaking change. Life is good. (by @billgates) --> | ||
|
|
||
| - [Improvement] Add support for `docker-compose.prod.override.yml` when using | ||
| `tutor local` commands |
Contributor
There was a problem hiding this comment.
- please add your github username at the end of changelog entry.
Contributor
There was a problem hiding this comment.
Note that adding the username in the changelog entry is optional. If OP does not need public recognition, that's fine :-)
Contributor
There was a problem hiding this comment.
@rhysyngsun Hi, are you good with merging this without mentioning your GitHub in the changelog entry? You can update the changelog if you want to. Thanks
Contributor
Author
There was a problem hiding this comment.
You can merge it as-is.
DawoudSheraz
approved these changes
May 6, 2025
Contributor
DawoudSheraz
left a comment
There was a problem hiding this comment.
Once the changelog is updated, this will be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for an optional
docker-compose.prod.override.ymlfile used fortutor localcommands. I'm proposing this because the current documentation suggests you can usedocker-compose.override.ymlto override services defined indocker-compose.prod.yml, but in practice this always errors.Any
tutor devcommands will try to use it and fail. Additionally even trying to runtutor local start(really anything that invokesdocker compose [start|up|restart]) causes the equivalent oftutor dev dc stopto run, which will fail as services likecaddyaren't defined for that project.This example if put in
docker-compose.override.ymlwill fail (under bothtutor devandtutor local), but if put indocker-compose.prod.override.ymlboth commands will work as expected: