Conversation
When we run `local/dev start` we expect that any running `dev/local` project will be stopped. Previously, we were running `docker compose ls` twice, and for all running Compose projects on the server. We changed this behaviour: 1. By swapping the project name check and the check for running compose projects, we run `docker compose ls` just once: for dev in local mode, and vice versa. 2. By checking only Compose projects in the context of local/dev. That way we ignore any other non-tutor project.
DawoudSheraz
approved these changes
May 20, 2025
github-project-automation
bot
moved this from In review
to Done
in Tutor project management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we run
local/dev startwe expect that any runningdev/localproject will be stopped. Previously, we were runningdocker compose lstwice, and for all running Compose projects on the server. We changed this behaviour:docker compose lsjust once: for dev in local mode, and vice versa.