fix: Fix the 'ln' command that fails silently#1239
Closed
lewisemm wants to merge 1 commit intooverhangio:mainfrom
Closed
fix: Fix the 'ln' command that fails silently#1239lewisemm wants to merge 1 commit intooverhangio:mainfrom
lewisemm wants to merge 1 commit intooverhangio:mainfrom
Conversation
- This command takes the form of: `ln -s source_directory target_directory`. - If the `target_directory` already exists on the file system, the command will fail with a message that is similar to what is shown below. `ln: failed to create symbolic link 'target_directory': File exists` - This message is not being logged (most likely due to how Docker's buildkit logs messages) and the build process fails when the '/scripts/copy-node-modules.sh' script is executed. - This fix adds a 'rm' command to first remove the 'target_directory' before the 'ln' command is executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command takes the form of:
ln -s source_directory target_directory.If the
target_directoryalready exists on the file system, the command will fail with a message that is similar to what is shown below.ln: failed to create symbolic link 'target_directory': File existsThis message is not being logged (most likely due to how Docker's buildkit logs messages) and the build process fails when the '/scripts/copy-node-modules.sh' script is executed.
This fix adds a 'rm' command to first remove the 'target_directory' before the 'ln' command is executed.