Skip to content

Ensure LMS_ROOT_URL is defined in i18n and assets settings modules #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdmccormick merged 2 commits into from
Aug 4, 2025
Merged

Ensure LMS_ROOT_URL is defined in i18n and assets settings modules #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a870a81
chore: add LMS_ROOT_URL to i18n and assets settings
Aug 1, 2025
6313b84
fixup! chore: add LMS_ROOT_URL to i18n and assets settings
Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tutor/templates/build/openedx/settings/partials/assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,8 @@
DATABASES = {
"default": {},
}
# Dummy value required for the static asset build steps to run,
# but it has no impact on the output produced by those steps.
LMS_ROOT_URL = "https://lms.local"

{{ patch("openedx-common-assets-settings") }}
3 changes: 3 additions & 0 deletions tutor/templates/build/openedx/settings/partials/i18n.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
DATABASES = {
"default": {},
}
# Dummy value required for the i18n build steps to run, but
# it has no impact on the output produced by those steps.
LMS_ROOT_URL = "https://lms.local"

derive_settings(__name__)

Expand Down