revert: fix: stop early SITE_ID override and document correct email configuration#1346
Merged
kdmccormick merged 2 commits intoreleasefrom Feb 6, 2026
Merged
revert: fix: stop early SITE_ID override and document correct email configuration#1346kdmccormick merged 2 commits intoreleasefrom
kdmccormick merged 2 commits intoreleasefrom
Conversation
This reverts commit 1a69d67.
eemaanamir
approved these changes
Feb 6, 2026
github-project-automation
bot
moved this from Pending Triage
to Done
in Tutor project management
Collaborator
Author
|
Thanks Eemaan. Followup discussions: #1182 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts:
As I wrote in the original issue, I don't think that removing the SITE_ID override fixes the email configuration bug. But it does introduce a breaking change, which is disrupting developers (by causing SiteNotFound error). I believe that this would also break production sites upon release of Tutor v21.1.0, which is counter to the Tutor philosophy of avoiding breaking changes between major versions.
I think we should revert this change for now, and then discuss a way forward to fix the email bug. I think there's a way to do it that doesn't cause a breaking change. But if we must do a breaking change, we should communicate it well keep it on
main(notrelease) so that it doesn't break Ulmo sites.